Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[full-ci] fix: render loading state before loading starts #7325

Merged
merged 3 commits into from
Jul 27, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 25, 2022

Description

Noticed that the Personal view showed the Resource not found component for a brief moment before the resource loader task was started. This is due to the task API not announcing itself as isRunning=true when there is no task instance, yet. Fixed in all views by adding a check for the absence of a loader task instance (in addition to the isRunning check).

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann self-assigned this Jul 25, 2022
@kulmann kulmann force-pushed the fix-loading-state-in-views branch from c93f488 to 4d0aa06 Compare July 25, 2022 10:17
@ownclouders
Copy link
Contributor

ownclouders commented Jul 25, 2022

Results for oC10Files5 https://drone.owncloud.com/owncloud/web/27070/21/1

💥 The acceptance tests failed on retry. Please find the screenshots inside ...

webUIFiles-breadcrumb_feature-L50.png

webUIFiles-breadcrumb_feature-L50.png

@kulmann kulmann changed the title fix: render loading state before loading before loading starts fix: render loading state before loading starts Jul 26, 2022
@kulmann kulmann changed the title fix: render loading state before loading starts [full-ci] fix: render loading state before loading starts Jul 26, 2022
@kulmann kulmann force-pushed the fix-loading-state-in-views branch from 89f74f4 to 31ffb91 Compare July 26, 2022 08:43
kulmann added 2 commits July 27, 2022 11:24
If the item is missing there's a warning in the browser console about
item not matching the required format.
@kulmann kulmann force-pushed the fix-loading-state-in-views branch from 31ffb91 to add7d7c Compare July 27, 2022 10:49
@kulmann kulmann force-pushed the fix-loading-state-in-views branch from add7d7c to adea522 Compare July 27, 2022 13:43
@@ -21,7 +21,7 @@ const propsData = {
active: false,
target: exampleNavItem.route.path,
icon: exampleNavItem.icon,
index: 5,
index: '5',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is this related? 🤔

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not. It just printed a warning to the console when running unit tests, so I fixed it. ;-)

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@kulmann kulmann merged commit c67f094 into master Jul 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-loading-state-in-views branch July 27, 2022 14:34
@kulmann kulmann mentioned this pull request Jul 28, 2022
9 tasks
@micbar micbar mentioned this pull request Aug 11, 2022
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants